Fix a bunch of old stuff and add some new features

lostkeys / Bits-and-Pieces-Theme-for-Pico

A personal wiki/knowledge base theme for Pico CMS

MIT License

47 stars 13 forks source link

Fix a bunch of old stuff and add some new features #10

Open 9hax opened 4 years ago

9hax commented 4 years ago

My changes add a footer element to display a copyright, Make the theme more responsive (Fixes #5 ), Change the text in dark mode to a brighter color to make it readable in sunlight, Stop code blocks from covering headings (Fixes #2 ), Hides Unnecessary Scrollbars (Different approach but same effect to #7 , Fixes #4 ), Updates the installation Docs in the Readme (Fixes #8 ), And Adds a note about being tested in Microsoft Edge.

lostkeys commented 4 years ago

Thanks a lot, really appreciate it!

I found a couple of issues that needs adressing before I can approve the PR

The left side of the footer collides with the aside menu i the menu is very large
The copy to clipboard button is now broken and positioned at the top right of the document causing a sidescroll. Most likely because you removed position relative on the code blocks.

9hax commented 4 years ago

i unfixed #2 for now because im too dumb for z-index and also removed the 100vh rule from the menu as it is autoscaled by the