search

losuler / pihole-dnscrypt-docker

A docker-compose for Pi-hole and DNSCrypt, daemonized with a systemd service file.
GNU General Public License v3.0
55 stars 14 forks source link

Question about dnscrypt ports #1

Closed Patanouk closed 4 years ago

Patanouk commented 4 years ago

Hi!

I have a question about the ports of the dnscrypt service in your docker-compose.yml

Is there any reason for using

` ports:

instead of ` expose:

as the port only need to be accessible from within the pihole container?

Regards

losuler commented 4 years ago

Thanks for mentioning this, I'm still learning docker. There wasn't any intention of mine to have those ports accessible outside of docker-compose internal network, so I'll fix this.