search

lotabout / skim.vim

vim support for skim
132 stars 19 forks source link

Fix skim version check #20

Closed anthraxx closed 1 year ago

anthraxx commented 2 years ago

fix: support future clap-styled version output of skim

The clap crate >= 3 as used in skim has a new default version option that resolves to a different output style including the application name in front of the actual version.

Switch the matchstr mode to magic and allow an optional sk application name prefix when matching for the current version. This allows to have a future proof version matcher which is also backwards compatible.

anthraxx commented 1 year ago

@lotabout The missing version has been fixed in latest skim: https://github.com/lotabout/skim/pull/489 Not only awaiting this PR and a skim.vim git tag :cat:

anthraxx commented 1 year ago

Sorry for the noise, but it seems @lotabout isn't very active nowadays. Looping in some commiters as this plugin is currently broken without this fix CC @junegunn

aschleifer commented 1 year ago

Will this ever be merged?

Without this fix the plugin is not working against latest versions of skim.

anthraxx commented 1 year ago

Sorry for the noise, but it seems @lotabout isn't very active nowadays. Looping in some commiters as this plugin is currently broken without this fix CC @junegunn

junegunn commented 1 year ago

@anthraxx This repository is a fork of fzf.vim of mine, so please stop mentioning me.