search

lotabout / skim

Fuzzy Finder in rust!
MIT License
5.1k stars 183 forks source link

Not properly clearing the screen when --height is set #494

Open leo-arch opened 1 year ago

leo-arch commented 1 year ago

Issue: As the tittle says, skim isn't properly clearing the screen at exit (abort) whenever --height is set (the screen isn't cleared at all in fact).

Expected behavior: clear the screen, just as it is done when --height isn't set (full screen).

Steps to reproduce:

ls | sk --height=20

Thank you very much in advance.

Update: Same thing with accept. This happens at least with version 0.10.1. Not there in 0.9.4.

paoloschi commented 1 year ago

just like that, I am also experiencing the same regression

timvisee commented 1 year ago

I'm seeing the same issue. Removing the height parameter fixed this.

liangkarl commented 1 year ago

I have checked v0.10.4. This issue still happens. In some terminal emulators, this issue even made skim unusable since the TUI would be messed up.

airelil commented 11 months ago

@liangkarl , it seems that using the --no-clear-start option helps here. A bit counter-intuitive to me though. Peek 2023-10-24 18-32-skim