search

lotgd / core

Core functionality for Legend of the Green Dragon, a text-based RPG game.
GNU Affero General Public License v3.0
152 stars 15 forks source link

Migrate to PHPUnit 7 #115

Closed Vassyli closed 5 years ago

Vassyli commented 6 years ago

Since PHPUnit 7 is out for a while, we'd like to use it instead of PHPUnit 5.7 due to it being up to date with PHP7. However, direct migration is impossible since test recognition relies on extending from the correct base class (which, in this case, still is PHPUnit 5.7). Additionally, some dependencies seem to rely on PHPUnit 5.7 still and don't work together with PHPUnit 7.

Vassyli commented 6 years ago

Changed text to mention PHPUnit 7 instead of 6. If only migration to PHP6 is possible right know due to dependencies, then this is okay, too.

Vassyli commented 6 years ago

Thanks to @nekosune for wanting to look into it.

Vassyli commented 5 years ago

Fixed in PR #128