search

lotgd / core

Core functionality for Legend of the Green Dragon, a text-based RPG game.
GNU Affero General Public License v3.0
152 stars 15 forks source link

Transition to a file-base configuration setup #47

Closed austenmc closed 8 years ago

austenmc commented 8 years ago

This is just easier than an environment-based one. We'll see how it goes...

Vassyli commented 8 years ago

lgtm. We maybe want to move away from ENV completely and make the configuration file path defineable (at least as an alternative) in the bootstrap directly. Currently this is what I'm doing manually in crate-www since env variables will not load (at least not on my system). This would give us the ability to store daenerys config together with symfony config (if we'd like to?).

austenmc commented 8 years ago

I was thinking of defining a default config path to address this issue, but yeah let's keep thinking about it and evolving it.

What do you mean environment variables arent working?

Vassyli commented 8 years ago

Defining a default config path inside of the core is difficult since that would be relative to the vendor root, not the crate root.

Could be a windows issue, values from .env are not loading. That's why I'm reading the file and storing everything via putenv into the environments.