search

lotgd / core

Core functionality for Legend of the Green Dragon, a text-based RPG game.
GNU Affero General Public License v3.0
152 stars 15 forks source link

Refactor ModelTestCase so I can use it outside of the Core. #64

Closed austenmc closed 8 years ago

austenmc commented 8 years ago

Find the configuration file for the tests from an environment variable. This way I can reuse ModelTestCase inside the module repos, but not have to have the same directory structure, namely that I think having a config/ directory would be very misleading for a module repo, so Ill put the config file within the tests/ directory.

Vassyli commented 8 years ago

Awesome! I started to awkwardly copy the config around using a script.. Much better!

The only issue I have: Usually, when you make changes to files I created, you (or probably your IDE) seems to remove all whitespace on an empty line. This makes the commit very difficult to read since there are a lot of changes that don't change anything at all. Can we resolve this issue somehow?

austenmc commented 8 years ago

But we don't want this white space, at least according to PSR2 (and my own sensibilities). :)

Vassyli commented 8 years ago

That's what I meant with we need to resolve this. You give me an argument to not do it and I'll need to find a possiblity to remove these. Interestingly, my PSR2 code check does give me an error for spaces on an empty line.