lots0logs / gh-action-get-changed-files

GitHub Action that saves changed files as JSON for use by other actions.
MIT License
88 stars 38 forks source link

HttpError: API rate limit exceeded, stacktrace does not cause action to exit non-gracefully #17

Open bagel-dawg opened 4 years ago

bagel-dawg commented 4 years ago

This action "fails" with the following output:

Run lots0logs/gh-action-get-changed-files@2.1.4
  with:
    token: ***
(node:301) UnhandledPromiseRejectionWarning: HttpError: API rate limit exceeded for installation ID 2506633.
    at /runner/_work/_actions/lots0logs/gh-action-get-changed-files/2.1.4/dist/index.js:7470:23
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async getCommits (/runner/_work/_actions/lots0logs/gh-action-get-changed-files/2.1.4/dist/index.js:337:14)
(node:301) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:301) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

This is probably due to my token running out of API requests. The issue is that this does not cause the job to fail.

I have subsequent actions that rely on these files to tell me if parts of my build needs to run. I would have expected this action to fail non-gracefully and kill the remainder of my build. Instead, my build continues as if no files changed, thus passing my status checks.