search

lotta-schule / lotta

Lotta Web Monorepo
https://lotta.schule
GNU Affero General Public License v3.0
4 stars 0 forks source link

fix(core-api): Send 404 when file has not been found, check id format #360

Closed ptitmouton closed 2 weeks ago

ptitmouton commented 2 weeks ago

See Sentry Issue: CORE-KBE and Sentry Issue: CORE-KBD

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@5f0c958). Learn more about missing BASE report. Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...pi/lib/lotta_web/controllers/storage_controller.ex 0.00% 3 Missing :warning:
apps/core-api/lib/lotta/guard.ex 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #360 +/- ## ======================================= Coverage ? 71.22% ======================================= Files ? 87 Lines ? 1842 Branches ? 0 ======================================= Hits ? 1312 Misses ? 530 Partials ? 0 ``` | [Flag](https://app.codecov.io/gh/lotta-schule/lotta/pull/360/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lotta-schule) | Coverage Δ | | |---|---|---| | [core-api](https://app.codecov.io/gh/lotta-schule/lotta/pull/360/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lotta-schule) | `71.22% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lotta-schule#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.