search

lotta-schule / web

Lotta Web Monorepo
https://lotta.schule
GNU Affero General Public License v3.0
4 stars 0 forks source link

feat(webapp): GroupSelect now adds an option for a 'None' selection #208

Closed ptitmouton closed 2 months ago

ptitmouton commented 2 months ago

As it's implemented in the admin user search, it closes #107

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 88.60759% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 63.58%. Comparing base (b6b290f) to head (ef52eb3). Report is 1 commits behind head on main.

Files Patch % Lines
packages/hubert/src/form/comboBox/ComboBox.tsx 90.24% 1 Missing and 3 partials :warning:
...es/webapp/src/article/editor/EditArticleFooter.tsx 0.00% 2 Missing :warning:
packages/webapp/src/shared/edit/GroupSelect.tsx 93.54% 1 Missing and 1 partial :warning:
...istration/categories/categories/CategoryEditor.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #208 +/- ## ========================================== + Coverage 63.42% 63.58% +0.15% ========================================== Files 351 351 Lines 5542 5566 +24 Branches 723 729 +6 ========================================== + Hits 3515 3539 +24 - Misses 1812 1815 +3 + Partials 215 212 -3 ``` | [Flag](https://app.codecov.io/gh/lotta-schule/web/pull/208/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lotta-schule) | Coverage Δ | | |---|---|---| | [hubert](https://app.codecov.io/gh/lotta-schule/web/pull/208/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lotta-schule) | `84.15% <90.24%> (+0.36%)` | :arrow_up: | | [storybook-addon-theme](https://app.codecov.io/gh/lotta-schule/web/pull/208/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lotta-schule) | `27.58% <ø> (ø)` | | | [webapp](https://app.codecov.io/gh/lotta-schule/web/pull/208/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lotta-schule) | `60.47% <86.84%> (+0.11%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=lotta-schule#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.