lotus-1 / LuckyPicture

week-2 Project
0 stars 3 forks source link

Naming conventions could be improved #23

Open MynahMarie opened 5 years ago

MynahMarie commented 5 years ago

The id nPic is not very descriptive and doesn't communicate the purpose of this element.

https://github.com/lotus-1/LuckyPicture/blob/c043ca6ce3739ad1924a66eab0d846a2ebf096e6/index.html#L13

It's good practice to choose good names for your variables and Ids so that if someone else reads your code, or if you go back to your code month later, you can understand the purpose of each line clearly. Something like searchBox or searchPic could've been more clear.

Noorb7188 commented 5 years ago

working on it