search

lotusnprod / lotus-web

Code for LOTUS web
https://lotus.naturalproducts.net/
MIT License
13 stars 5 forks source link

fixing of Bioschemas annotation #6

Open egonw opened 3 years ago

egonw commented 3 years ago

it would be a small snippet of JSON-LD wrapped in a <script> element... the content can be autogenerated from the content on the page. I will make a template for https://lotus.naturalproducts.net/compound/lotus_id/LTS0249032 asap.

egonw commented 3 years ago

Seems I already did before: https://github.com/mSorok/LOTUSweb/pull/1/commits/301e6eb884de4cbbb4af3b4b742a5bcec5dc4da4

egonw commented 3 years ago

@mSorok, in the patch, I did not realize the { in line 17 and the } in line 27 need to be escaped. How do I do that?

mSorok commented 3 years ago

what do you mean by "escaped"? Othewise you can either create another pull request, either paste here the correct way of doing, and I'll update in my code

egonw commented 3 years ago

so, the templating system normally uses the {} to indicate that it need to replace that section with the variable thing. So, the system now interprets the curly brackets at lines 17 and 27 as start end end indicator that it needs to replace something... they are control instructions. "escaping" is the term used to indicate it is not a control structure, but raw string content...

So, I'm trying to figure out how to do this, but that's actually not obvious in React. I'm looking at https://github.com/facebook/react/issues/1545 which mention a few approaches, but I'm not familiar with React enough to see which one is going to work :/

egonw commented 3 years ago

Okay, going to make a patch. We'll see if that solve it, if not, I'll make another patch. I am not sure how to get the server quickly set up from source here :(

egonw commented 3 years ago

So, in https://github.com/mSorok/LOTUSweb/commit/ba9125a2dfdec2f0ceaec58536eae97ddfcaf8a0#diff-3939054327bc78cf3b5c1e4cacc308feaf29a5d2d00f18f78d8bade77ec82d0eL17 you actually had to remove the curly brackets because it was getting recognized as control instruction...

egonw commented 3 years ago

I have an attempt here: https://github.com/mSorok/LOTUSweb/pull/7

But no clue if this works... I don't have a LOTUS development environment here, and cannot test it easily

egonw commented 2 years ago

@mSorok, any change we can pick this up? I need your guidance as I do not know the website system.

mSorok commented 2 years ago

Hi, I thought I integrated these in the latest functional version... apparently it didn't work. I don't work in the Steinbeck lab anymore, and eventually add some implementations in LOTUS on a hobby basis, so such things might take time. Kohulan took over some of my projects, he might be more operative than me for this.