search

lotusprey / otraku

An unofficial AniList client for Android and iOS
GNU General Public License v3.0
347 stars 12 forks source link

feat: Previews for themes in settings page. #44

Closed Curstantine closed 2 years ago

Curstantine commented 2 years ago

closes #43

Curstantine commented 2 years ago

Not sure if it's a good idea to merge to master since the riverpod migration is still going on, tell me if I should re-pull

Curstantine commented 2 years ago

Screenshot_20220727-193329_Otraku-dev

Curstantine commented 2 years ago

I feel like I should use a font with lower priority font size/color for the theme names.

lotusprey commented 2 years ago

will finish reviewing in 20 minutes; I will request a few changes

Curstantine commented 2 years ago

Haha, I'll fix these and push it. 😅

Edit: In few hours, electricity just went down here.

lotusprey commented 2 years ago

oh and yeah, use the dev branch

Curstantine commented 2 years ago

I didn't remove the small shapes (I feel like they should be there), but I did some changes and added a FAB.

Screenshot_20220727-233232_Otraku-dev

lotusprey commented 2 years ago

I just realised that this introduces a different behaviour for how themes are handled - before, you could use a dark theme even in light mode (and vice versa). Now I will have to make more light themes 🤔

Curstantine commented 2 years ago

Ah sorry, I forgot to mention that. Since you can explicitly change the "mode", it made no sense for me to add both dark and light themes in both the categories.

lotusprey commented 2 years ago

Yeah, I was planning to do this change anyway. I just didn't realise this pr would introduce it 😅