lotze / COMPoissonReg

COMPoissonReg R package
GNU General Public License v2.0
9 stars 4 forks source link

z-function evaluating to infinity #11

Closed andrewraim closed 3 years ago

andrewraim commented 3 years ago

Moved this out of a random TODO file. Need to see if any of this is still relevant.

We currently don't throw errors if the z-function evaluates to infinity. This causes some weird results, like the parameters lambda = exp(5.25), nu = 0.4 always causing rcmp to draw 203 as the value.

Add ymax as an option (not global) to regression functions

There is an issue with formula processing. Here is a small example to illustrate.

y <- rcmp(250, lambda = 10, nu = 0.95)
# Doesn't work
out <- glm.cmp(y ~ 1)
out <- glm.cmp(y ~ 1, formula.nu = ~ 1)
# Workaround
out <- glm.cmp(y ~ 1, formula.nu = y ~ 1)
andrewraim commented 3 years ago

These issues have all been resolved in the codebase now