Support user-configurable display parameters

loudnate / openaps-monitor

Status dashboard for your openaps project

MIT License

6 stars 8 forks source link

Support user-configurable display parameters #24

Closed oskarpearson closed 9 years ago

oskarpearson commented 9 years ago

Allow users to select either mg/dL or mmol/L display parameters, so as to support other countries.

Rename ReportFile class to Settings, so that it's more general

loudnate commented 9 years ago

Great work! I'm looking forward to merging this when I'm next on my laptop.

There is no versioning strategy for this project yet, so for now I'm going to continue to accept PRs straight to master.

loudnate commented 9 years ago

Yeah, you make a good point that there are probably many more cases where configurable values should stay in one unit.

It's not really OpenAPS's decision to keep values in one unit, it's really because that's what the MM data format uses.

I'm good with this for now. Let's shoot for reading the units directly from the medtronic vendor report once that's available (PR's on openaps are welcome!)