louicoder
commented
5 years ago I think we can go ahead and merge this PR as well since it's changes are already merged. @Anekenonso and @udms100 . Please take note of this.
Closed Anekenonso closed 5 years ago
louicoder
commented
5 years ago I think we can go ahead and merge this PR as well since it's changes are already merged. @Anekenonso and @udms100 . Please take note of this.
Looks Good To Me (LGTM). @Anekenonso
Just a couple of things to note however
You should describe what your PR(Pull Request) achieves so that everyone knows what it implements. I'm going to create a PR template so that it makes it easy for you to just fill in the different sections.
You can only make Pull Requests to develop branch and not the master branch. This is because we want to keep the master branch as clean as possible.
When you start a task go to projects tab and move the task to the in
progress cardand also if it's not assigned to you or assigned to someone else then assign it to yourselfYou also assign the reviewer to the PR (Pull Request) and in this case it's me for now. I will also do the same. In cases where there's code change it will require you to pull my branch onto your machine and test my implementation to make sure everything works as I claim and leave any comments on the PR