Closed callumfrance closed 1 year ago
Amazing! Thanks a lot for your effort, I really appreciate it.
No problem
Just reiterating that I did not test this code that you have now merged...
I think I already did make an error - the /arnis.py
file references the src/main.py
file by calling a run()
function. The run()
function does not exist.
So two options -
arnis.py
file and run the code straight from src/main.py
. This is the quick-fix solution.src/main.py
into functions, most importantly with a run()
function that becomes the entrypoint and start of the program. This may take a bit of time but you should get better code from it as a result.No worries, I tested it before merging it. It was nevertheless working. But thanks for pointing that out, I'll fix it! Edit: I'll also have to edit the requirements.txt, there are a lot of unnecessary packages. Will do that later today.
Hey @louis-e,
This seems like a really cool project so here are some things you might want to try out.
src/
directory to keep code clean and manageablearnis.py
file into several smaller filesblack
to style the code consistently (run withmake style
and check withmake style-check
)flake8
linter to check that the code is formatted nicely (run withmake lint
).flake8
but you shouldn't need to worry about that too muchMakefile
so that you can add your own custom commands toarnis
.gitignore
so any python-adjacent files that you do not need to worry about will not be stored in GitHubFull disclosure - I have not ran the program so take this pull request with a grain of salt. I haven't actually edited the source code, mostly just moved it into new files as well has ran the linter and auto-formatter on it, but you never know.