louis-e / arnis

Arnis - Generate cities from real life in Minecraft
GNU General Public License v3.0
260 stars 18 forks source link

Improve the code health of arnis #5

Closed callumfrance closed 1 year ago

callumfrance commented 1 year ago

Hey @louis-e,

This seems like a really cool project so here are some things you might want to try out.

Full disclosure - I have not ran the program so take this pull request with a grain of salt. I haven't actually edited the source code, mostly just moved it into new files as well has ran the linter and auto-formatter on it, but you never know.

louis-e commented 1 year ago

Amazing! Thanks a lot for your effort, I really appreciate it.

callumfrance commented 1 year ago

No problem

Just reiterating that I did not test this code that you have now merged...

I think I already did make an error - the /arnis.py file references the src/main.py file by calling a run() function. The run() function does not exist. So two options -

louis-e commented 1 year ago

No worries, I tested it before merging it. It was nevertheless working. But thanks for pointing that out, I'll fix it! Edit: I'll also have to edit the requirements.txt, there are a lot of unnecessary packages. Will do that later today.