search

louis-e / arnis

Arnis - Generate cities from real life in Minecraft
GNU General Public License v3.0
432 stars 23 forks source link

Wide rivers #76

Closed scd31 closed 1 month ago

scd31 commented 1 month ago

Working on adding rivers. Code works as-is, but it's very slow. Takes about 40 minutes to run on my small city. Have some improvements locally but I haven't pushed them up yet.

This required a bit of refactoring so that we could handle relations. I cleaned up some related code at the same time. And this is also based on my other PRs, so I recommend looking at them first (as some of their code is duplicated in this PR)

Before:

freddy_before

After:

freddy_after

This makes a big difference to how my city looks!

louis-e commented 1 month ago

I love your inversed floodfill approach. Awesome work, thanks for your time and effort! :)

scd31 commented 1 month ago

@louis-e Sorry, I was out for a wedding late last night and only just got up. I think we should to revert this PR and #75 as they were both draft PRs. This one I'm working on optimizing more (and tbh, it should probably be tested a bit more as I refactored a bunch of code) and the other one I left some questions on in the PR.

scd31 commented 1 month ago

Actually, we'd probably okay to not revert (I can put up new PRs to finish things) but #75 has a few questions I was wondering about

scd31 commented 1 month ago

Sorry for all the spam, but my open PRs should fix all the WIP stuff! Can probably ignore my above comments