louis-ev / Cargo-Bikes-Size-Comparator

Cargo bike size comparison tool
GNU Affero General Public License v3.0
28 stars 7 forks source link

Question: alignment with the back #11

Closed louis-ev closed 2 months ago

louis-ev commented 4 months ago

Not sure what to do here: http://localhost:5173/?bikes=[%22nakamura%22]

The Nakamura Crossover has its monkey bars welded to the frame it seems, and the length accounts for the back of the monkey bar. Which is also the case for the Decathlon R500E, but not for most other longtails (such as the multitinker

image image

Which makes the result deceptive in favour of the multitinker.

Any ideas on handling this situation?

theodorefaure commented 4 months ago

Could allowing the user to control the alignment of the bikes be a solution? Like on carsized.com. CleanShot 2024-05-14 at 10 30 49@2x

Otherwise I can't think of another solution without specifying the length measure: full bike / wheel to wheel.

louis-ev commented 4 months ago

The only alignment we can propose with the data we have is back, center or front. On reddit multiple people asked for a way to aligne the saddles, for example, but this means adding that information for each bike. If someone wants to contribute this, we can add it sure :)

What we could do for now is show a small range slider in the sidebar to change the horizontal alignment, per bike, when a bike is selected. So someone could change the alignements of bikes to match the saddles, for example. We could store that information in the localstorage, so that it persists if reloading the page (by mistake). And if we display this data, someone could more easily contribute saddle position so we could add it via github?

louis-ev commented 4 months ago

I just asked ChatGPT 4o and got mixed results (but it understood the query easily, which is pretty good):

image image image

Overall a few are spot on, the rest are close but not quite.

theodorefaure commented 3 months ago

Not bad! However, saddle position is variable; in some bike photos, it might be higher than in others. Hence, it's not a reliable reference.

The only precise reference we could get for each bike would be the frame size (all bike manufacturers provide it).

We could add those values (like on bikeinsight) and create a way to manually place the High-Resolution Photo on top of the generated frame drawing.

But this starts to feel really complex to just be able to compare cargo bike sizes 😄

louis-ev commented 3 months ago

Yes, not ideal since the saddle can move. There was a suggestion on reddit to add individual sliders for enabled bikes, to move left/right the bike silhouette and manually adjust the position to compare. What do you think? Much less complicated and more adaptable. Ideally this should be stored in the URL when sharing, but this is a bit of work (and would need a fix to make past URL work with the new logic, an array of objects I guess).

I see your point about the frames but I'm not sure this is useful. Or we would need much more precise measures/cropping, it is a bit sloppy right now!

louis-ev commented 3 months ago

Alright, added this setting to adjust the bike position individually:

image

image

Available online: https://bikes.louiseveillard.com/