louis-ev / Cargo-Bikes-Size-Comparator

Cargo bike size comparison tool
GNU Affero General Public License v3.0
32 stars 7 forks source link

Feature: draw silhouette in color #3

Closed louis-ev closed 5 months ago

louis-ev commented 5 months ago

A solid color to improve legibility, blend mode?

louis-ev commented 5 months ago

@ontl

Layer blending set to multiply seems better for outlines – I think we can set automatically when switching to multiply and back to default when disabling outlines.

Also, I'm thinking a checkbox "outlines" is clearer than a toggle:

image
louis-ev commented 5 months ago

Ok, so I tried giving each bike a color picked (picked arbitrarily from the frame or components then tweaked) but I'm not convinced about the results :

image image

What do you think? I think I prefer with the contrasted color.

nclm commented 5 months ago

This is great! Would be useful if the UI highlight on the list of the left would match the colour of the outline? Right now it’s not always necessarily clear which bicycle is which.

ontl commented 5 months ago

Yeah I definitely found while playing around with it that I needed darker colours to stand out well against the BG.

I think it's nice for the bikes to have colours that match their frames.

But if that adds extra friction when adding bikes to the database, might want to have colours be automatically selected. Really comes down to how much work you want to do when adding each bike :)

And I like @nclm 's idea about indicating the outline colour somewhere in the UI. Could replace the green highlight, or could be like a coloured tab on the tip of each bar (but I think just full highlight replacement) Screenshot 2024-05-13 at 11 13 54 AM

louis-ev commented 5 months ago

Implemented ! Just the tip, full highlight made the text not legible.