louis-kevin / vcr

A dart VCR
https://pub.dev/packages/vcr
MIT License
9 stars 4 forks source link

Support for null safety #2

Closed jibiel closed 1 year ago

jibiel commented 3 years ago

Is there any plans to migrate the package to null safety?

vcr is currently complicates migration to null safety for the apps that depend on it.

The easiest way to do this would be to:

There is also a PR that solves the issue by completely dropping the mockito dependency: https://github.com/keviinlouis/vcr/pull/1.

So, how should we go about this?

alex-min commented 3 years ago

I don't think mockito is necessary, the package is small and just overriding the methods works.

I'm currently using my null saferty fork of vcr in my project, in the mean time the PR is merged you can replace vcr in the pubspec file by my fork:

  vcr:
    git:
      url: https://github.com/alex-min/vcr.git
      ref: de33eec6831be95b4e55eac4f661c6e3d0df3822
jibiel commented 3 years ago

@keviinlouis Any input on that?

alex-min commented 3 years ago

To people reading this, I've published the forked package with null safety https://pub.dev/packages/vcr2/, I'm going to maintain it forward, I need it for my project.

louis-kevin commented 1 year ago

Hello There, sorry about the longest delay ever, but I added null safe and refactor a bit, if you guys are using this package yet, plz check if works for you!

Thanks!

louis-kevin commented 1 year ago

cc @alex-min @jibiel