search

louis-langholtz / PlayRho

An interactive physics engine & library.
zlib License
133 stars 24 forks source link

fix target name in build shared #426

Closed toge closed 2 years ago

toge commented 2 years ago

Description - What's this PR do?

I can't build playrho shared build only. It seems to be caused by CMakeLists.txt bug.

Impacts/Risks of These Changes?

Nothing at all.

Where should a reviewer start?

Only 1 line.

How should this be tested?

I build Playrho locally with PLAYRHO_BUILD_SHARED=ON PLAYRHO_BUILD_STATIC=OFF.

Any background context you want to provide?

I am trying to create conan recipe for PlayRho. https://github.com/conan-io/conan-center-index/pull/11728

This bug prevents conan-center-index's CI test of PlayRho.

Related Issues

Related Pull Requests

Screenshots (if appropriate)

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

coveralls commented 2 years ago

Coverage Status

Coverage increased (+0.0002%) to 98.819% when pulling f81e307a06c7d74e8ae439e3cdd12590fdd4b48d on toge:fix-shared-target into a3a91554cf9b267894d06a996c5799a0479c5b5f on louis-langholtz:master.