After installation the new Flatpak of tuner 1.5.4; it do not start

Prust57 commented 2 weeks ago

If I start tuner from terminal I get the following error

Failed to load module "xapp-gtk3-module"

(com.github.louis77.tuner:2): CRITICAL : 17:13:53.619: Settings.vala:87: Verbindung ist gescheitert: No such file or directory

my system Linux Mint 22 Kernel 6.8.0-47

Regards

technosf commented 2 weeks ago

@Prust57 Would you be willing and able to run Tuner in a debug environment and step through it to get more info?

Prust57 commented 2 weeks ago

Yes, I would do that. But you have to know that I am not an IT-Specialist. Anyway tell me what I have to do and how I have to start the debug mode. regards

technosf commented 2 weeks ago

I believe this is an issue with GLib.Settings in Window or Application: It should be getting built (See Valadoc, but either isn't or wasn't included. Why the app is working for others if this is the case, TBD.

technosf commented 2 weeks ago

@Prust57 @ebpaul75 @jowuerg

Please take a look at the Development doc

I would like to pin down in which release the issue was introduced. If you could set up a development environment:

git clone https://github.com/louis77/tuner.git
cd tuner

and then check out and run from the command line, in turn, tags v1.5.4, v1.5.3 and 1.5.2:

git checkout v1.5.4
meson setup --buildtype=debug builddir
ninja -C builddir
./builddir/com.github.louis77.tuner

See if you have the issue, and document messages on the command line.

Thank you for you help!

Prust57 commented 1 week ago

Hi, I installed on my PC (virtualBox Linux Mint 21.3 kernel 6.8.0-47) the following commands: sudo apt install git valac meson sudo apt install libgtk-3-dev libgee-0.8-dev libgranite-dev libgstreamer1.0-dev libgstreamer-plugins-bad1.0-dev libsoup-3.0-dev libjson-glib-dev

git clone https://github.com/louis77/tuner.git cd tuner

meson setup --buildtype=debug builddir ninja -C builddir ./builddir/com.github.louis77.tuner

I get the following error: ./builddir/com.github.louis77.tuner

(com.github.louis77.tuner:10620): GLib-GIO-ERROR **: 16:15:23.516: Settings schema 'com.github.louis77.tuner' is not installed Trace/Breakpoint ausgelöst (Speicherabzug geschrieben)

technosf commented 1 week ago

I have been looking at com.github.louis77.tuner.gschema.xml and wondering when it got compiled. Thanks @Prust57, I'll double down on that. In the meantime, would you try with version 1.5.2 to see if you get the same error?

angeld-jr2 commented 1 week ago

flatpak sandbox permissions error.

strace said:

[pid 36237] connect(17, {sa_family=AF_UNIX, sun_path="/run/dbus/system_bus_socket"}, 110) = -1 ENOENT (No such file or directory)

You can start unfiltering DBUS calls:

flatpak --socket=system-bus run com.github.louis77.tuner

nekrub2 commented 1 week ago

Had also a crash with this new version on LM22 cinnamon. The crash in systems says: The package providing /app/bin/com.github.louis77.tuner could not be found. If you want to generate a stack trace for this crash report, please reinstall it. Futhermore I found data in /tmp/mintreport/crash mintreport crash.zip

Prust57 commented 1 week ago

Sorry I did not try with older versions because I'm a little bit busy at the moment. But in the annex you see my update list. It shows that my last version was 1.5.2 and it runs.

Then I tried the command from "angeld-jr2", the result is that Tuner starts and run but I get the following messages: Command: flatpak --socket=system-bus run com.github.louis77.tuner

Gtk-Message: 08:49:33.164: Failed to load module "xapp-gtk3-module" (com.github.louis77.tuner:2): Gtk-WARNING : 08:49:33.674: Could not load a pixbuf from icon theme. This may indicate that pixbuf loaders or the mime database could not be found. (com.github.louis77.tuner:2): WARNING : 08:49:34.537: Window.vala:355: Auto-play enabled (com.github.louis77.tuner:2): WARNING : 08:49:34.537: Window.vala:357: Last played station is: fccbd5cc-5583-4a25-9cad-f59e45156cf9 (com.github.louis77.tuner:2): WARNING **: 08:49:34.633: Window.vala:439: storing last played station: fccbd5cc-5583-4a25-9cad-f59e45156cf9

Tuner_02

Prust57 commented 1 week ago

Hi So now I found a little bit time to build tuner like tags v1.5.4, v1.5.3 and 1.5.2 The result files you will find in the annex. The problem was that on v1.5.2 I can't check out. But in my view the bug on tuner was not in v1.5.2. Earliest in v1.5.3 but I don't know. I hope you will find out what is going wrong. Regards

tuner-v152.txt tuner-v153.txt tuner-v154.txt

technosf commented 1 week ago

@Prust57 Thanks for putting in the effort! The tag for 1.5.2 is "1.5.2", not "v1.5.2" I created a clean Mint install an started building versions of Tuner and I get the gschema issue even as far back as 1.4.2. At some point, on my main system, the schema got compiled and installed and hung out so that failures to compile haven't affected Tuner. I am trying to research how to get GTK Schema compiles to work in Meson.

Prust57 commented 1 week ago

Hi Sorry. for my mistake. In the annex the new result file concerning 1.5.2

tuner-152.txt

But you will see the result is the same. Anyway it's for me difficult to help. But if you have a new version do not hesitate to send it for testing. At the moment I can live with the temporary solution of "angeld-jr2" -> flatpak --socket=system-bus run com.github.louis77.tuner

Regards

x-dean commented 1 week ago

Same in Fedora Linux 40 (Workstation Edition)

technosf commented 5 days ago

With a lot of poking around I've found a few thing I'll throw out here for future reference:

I didn't find the Python install scrips getting run, and ideally getting rid off it and having meson do the gschema install would be ideal.
I found that ninja -C builddir didn't compile the gschema
I found that meson install -C builddir did compile the schema
Once the schema is installed meson compile -C builddir works, and so does ninja -C builddir
I found that installing the icons happened before installing the schema
I found that installing the icons was erring out because of looking for a theme index.
I added a switch to the icon install to ignore missing theme index
Running in the sandbox, Tuner theme changes work. Outside of the sandbox, theme is stuck.

With that, I've updated the development branch and rolled a flatpak on my clean system, and tuner finds the schema and runs. If you could try building the flatpak from development to confirm, I'd appreciate it:

apt-get install flatpak-builder
flatpak remote-add --user --if-not-exists elementary https://flatpak.elementary.io/repo.flatpakrepo
flatpak install elementary io.elementary.Sdk//8 io.elementary.Platform//8
git checkout development
flatpak-builder --force-clean --user --sandbox --install build-dir com.github.louis77.tuner.yml
flatpak --user run com.github.louis77.tuner

Regarding getting local builds to run, the process requires the schema to be installed (but try the flatpak build first please, so as not to have local gschema hiding issues) :

rm -R builddir
meson setup --buildtype=debug builddir
meson install -C builddir
./builddir/com.github.louis77.tuner

Please let me know what you find. Thanks!

bztd commented 5 days ago

@technosf If the solution is not quick, I suggest applying the patch to the flathub package repository to temporarily fix the problem. Another solution is to grant the permission mentioned above, but I don't think that will happen.

technosf commented 5 days ago

@bztd I think the changes I put in place should address the issue with gschema not being installed (the Settings issues), which I could replicate on a clean system, and get fixed in a local flatpak build off the new development update. I wanted some validation before rolling a new release.

I can't speak to the permissions stuff from @angeld-jr2 - I built and installed it in the sandbox because it was a dev build... Release builds are not going into the sandbox AFAIK.

If theres more I should know, please if you could expound as I am coming to flatpaks without prior experience :)

bztd commented 5 days ago

In fact, I haven't reviewed the code enough to understand why the error occurred. I only identified the part of the code that was causing it (I thought it was due to an attempt to identify the theme through the system D-Bus, which it doesn't have access to). For the Flathub repository, could you create a beta branch to test the fixes, or simply make them and not merge them into the main branch so we have a testing package?

technosf commented 5 days ago

I had opened #143 for theme issues etc. As I mentioned, on my fresh system, themes work when run in the sandbox. Themes don't work on my main system. Some testing to do... But themes aren't read by the app, only the prefer dark preference is twiddled

This ticket I think the only issue is GIO Setting schema not getting compile - that was causing the crashes, and hopefully the fix is in the development branch now.

bztd commented 4 days ago

The problem does not occur in the compilation:

https://github.com/flathub/com.github.louis77.tuner/pull/14

To install:

flatpak install --user https://dl.flathub.org/build-repo/140253/com.github.louis77.tuner.flatpakref

technosf commented 3 days ago

@bztd that install gives me:

** (com.github.louis77.tuner:2): WARNING **: 13:52:07.558: Application.vala:81: Settings path: /com/github/louis77/tuner/
Gtk-Message: 13:52:07.565: Failed to load module "xapp-gtk3-module"

** (com.github.louis77.tuner:2): CRITICAL **: 13:52:07.684: Settings.vala:87: Could not connect: No such file or directory

** (com.github.louis77.tuner:2): CRITICAL **: 13:52:07.684: Settings.vala:107: Could not connect: No such file or directory

@Prust57 - same for you? @bztd - I'd like to set up a flathub beta repo - could you help? Hit me up on Discourse pls.

bztd commented 3 days ago

@technosf Just create a branch in the repository with the name "beta"

bztd commented 3 days ago

The program runs normally. The output:

(com.github.louis77.tuner:9): WARNING : 18:19:29.243: Application.vala:81: Settings path: /com/github/louis77/tuner/ Gtk-Message: 18:19:29.246: Failed to load module "xapp-gtk3-module"

In my case I run:

flatpak run --branch=test com.github.louis77.tuner

I don't think I have residual configuration. I will do a clean installation to confirm.

Prust57 commented 2 days ago

For me the same, see following (on both commands the same): flatpak run com.github.louis77.tuner flatpak run --branch=test com.github.louis77.tuner

(com.github.louis77.tuner:2): WARNING : 10:13:37.575: Application.vala:81: Settings path: /com/github/louis77/tuner/ Gtk-Message: 10:13:37.582: Failed to load module "xapp-gtk3-module" (com.github.louis77.tuner:2): CRITICAL : 10:13:37.702: Settings.vala:87: Verbindung ist gescheitert: No such file or directory (com.github.louis77.tuner:2): CRITICAL : 10:13:37.703: Settings.vala:107: Verbindung ist gescheitert: No such file or directory

Regards, Pius

bztd commented 2 days ago

On my PC it runs normally. It seems to be due to a residual configuration, it has happened to me before but this time I can't find the configuration that is being overwritten.

Could you try:

flatpak install --user https://dl.flathub.org/build-repo/140749/com.github.louis77.tuner.flatpakref

It should work. If so, I suggest you merge it to solve the problem.

bztd commented 2 days ago

@technosf Have you made a working local build for the org.freedesktop.Platform runtime, because I see that it is suggested to use the elementary SDK?

Prust57 commented 1 day ago

Hi, I did the following commands: flatpak install --user https://dl.flathub.org/build-repo/140749/com.github.louis77.tuner.flatpakref com.github.louis77.tuner Berechtigungen: ipc network fallback-x11 pulseaudio wayland x11 dbus access [1] bus ownership [2] [1] org.freedesktop.Notifications, org.gtk.vfs.* [2] org.mpris.MediaPlayer2.Tuner KENNUNG Zweig Op Gegenstelle Herunterladen

[✓] com.github.louis77.tuner.Locale test i tuner-origin 26.1 KB / 303.1 KB
[✓] com.github.louis77.tuner test i tuner-origin 14.6 MB / 24.2 MB Installation abgeschlossen.

Then I started tuner from terminal and icon. It seems to be ok. Tuner runs and from terminal I got the following messages: flatpak run com.github.louis77.tuner

Gtk-Message: 07:40:08.328: Failed to load module "xapp-gtk3-module" (com.github.louis77.tuner:2): Gtk-WARNING : 07:40:09.233: Could not load a pixbuf from icon theme. This may indicate that pixbuf loaders or the mime database could not be found. (com.github.louis77.tuner:2): WARNING : 07:40:11.309: Window.vala:353: Auto-play enabled (com.github.louis77.tuner:2): WARNING : 07:40:11.309: Window.vala:355: Last played station is: fccbd5cc-5583-4a25-9cad-f59e45156cf9 (com.github.louis77.tuner:2): WARNING : 07:40:11.647: Window.vala:437: storing last played station: fccbd5cc-5583-4a25-9cad-f59e45156cf9 (com.github.louis77.tuner:2): WARNING **: 07:40:12.437: Favicon.vala:66: Failed to process favicon https://ibb.co/jZsV775: Format der Bilddatei unbekannt

But for me it's ok and I can hear music

Many Thanks, Pius

technosf commented 11 hours ago

@bztd I have not made a working local build for the org.freedesktop.Platform runtime, I am using Elementary. Talking of residual configurations - I have found that on the fresh Mint install I did. After trying various builds, a build that didn't work because of the missing gschema started working, and on looking for gchema.compiled file didn't find any, nor com.github.louis77.tuner.gschema.xml files. I am going to flush that system again.

I pushed the flathub request #15 - I would like a better understanding of what the Windows patch does, in that I want to clarify if it's to facilitate how the build is done, or a code change that should be rolled into the Tuner repo and the patch removed from a future release?

technosf commented 10 hours ago

@Prust57 - these are informational messages. They are coded as 'warnings' as 'debug' messages have to be enabled, and it's not clear how to have the app know that. Warnings work. Favicon messages - they are more varied due to station favicons urls producing all kinds of files, the invalid ones being ignored but logged.

** (com.github.louis77.tuner:2): WARNING **: 07:40:11.309: Window.vala:353: Auto-play enabled
** (com.github.louis77.tuner:2): WARNING **: 07:40:11.309: Window.vala:355: Last played station is: fccbd5cc-5583-4a25-9cad-f59e45156cf9
** (com.github.louis77.tuner:2): WARNING **: 07:40:11.647: Window.vala:437: storing last played station: fccbd5cc-5583-4a25-9cad-f59e45156cf9
** (com.github.louis77.tuner:2): WARNING **: 07:40:12.437: Favicon.vala:66: Failed to process favicon https://ibb.co/jZsV775: Format der Bilddatei unbekannt

technosf commented 9 hours ago

@bztd Committed the flathub build, scrubbed my test system, and installed the build (now the stable build). The gschema did get installed and Tuner works.

@Prust57 - can you purge, reload Tuner from the main repo and give it a try? To check if the gschema got installed:

updatedb
locate louis77|grep gschema

louis77 / tuner

After installation the new Flatpak of tuner 1.5.4; it do not start #142