search

louisa-uno / dmarket_bot

This repository is an english translation of https://github.com/timagr615/dmarket_bot
14 stars 2 forks source link

It runs but isn't fully functional yet #7

Closed Cfomodz closed 8 months ago

Cfomodz commented 9 months ago

Fixes #3 Fixes #4

It still doesn't work as intended, but will run. main is completely broken as far as I am aware. I am making a PR to main with broken code. Still, I believe this will give us a better foundation to continue collaborating on the optimal solution than where we are now. Once I finish debugging the db issues so that it "works" (does something productive) I will create a dev branch on my fork and start working on new modifications there.

Please note: Running this in its current state will delete all of your targets as that is a feature, not a bug, of the bot - since it wants to create all new ones based on the immediate current market. The 'creating new ones' bit doesn't work, because the 'getting the current market' doesn't work (see above, that is what I am going to begin fixing immediately after this), so effectively all it does is delete your targets and doesn't buy or sell anything at present because it doesn't have market data on either your current items to create offers (sell) or the available offers to make targets (buy).

Cfomodz commented 8 months ago

Fixes #8 - it sells everything that is on-market (on dmarket as opposed to on Steam) so long as you purchased it on dmarket (did not depo it directly from your steam account) as it needs the buyPrice (the amount you bought it for) to know how much to sell it for... or at least it uses it... I assert that it could just go get a reasonable price for it based on the market data... but what do I know ;) At any rate, selling works as of this patch.

louisa-uno commented 8 months ago

@Cfomodz I had a look at it and it seems good. Thank you