search

louisabraham / pydivsufsort

Python package for string algorithms ➰
MIT License
38 stars 4 forks source link

[WIP] Separate Frontend and Backend #33

Closed seanlaw closed 3 years ago

seanlaw commented 3 years ago

This is an initial attempt to address #31

louisabraham commented 3 years ago

Thanks a lot for this contribution! Not sure why you use a PR for this but not for the other commits already pushed to master.

What is the status of travis? I don't see the CI results anymore

seanlaw commented 3 years ago

Thanks a lot for this contribution! Not sure why you use a PR for this but not for the other commits already pushed to master.

So, initially, I needed to set up Github Actions so that it would be triggered by a PR. So the initial commits was me trying to set it up just enough to not affect TravisCI.

What is the status of travis? I don't see the CI results anymore

I did not remove or change any of the TravisCI components so I am not sure why you are not seeing the CI results anymore 😅. Can you investigate?

The only thing that I can think of is the pyproject.toml file affecting things. I am going to reverse that until I figure things out

louisabraham commented 3 years ago

Yeah, I think it's best to revert all your changes and put them on a separate branch.

seanlaw commented 3 years ago

Will do. In case it wasn't clear, my original commits for setting up Github Actions needed to be merged into master. I just bypassed the branch as it was faster. Once I got Github Actions set up and able to trigger with PRs (on a new branch), then I could switch over. However, me setting up Github Actions (this excludes pyproject.toml) should not have affected TravisCI at all.

I just wanted to clarify. I will revert the changes except for the Github Actions component.