louisabraham / pydivsufsort

Python package for string algorithms ➰
MIT License
38 stars 4 forks source link

Add Linting/Code Formatting #9

Closed seanlaw closed 4 years ago

seanlaw commented 4 years ago

@louisabraham Would it be useful to add flake8 and black for linting and code formatting, respectively?

Perhaps, this is something we can do later once Travis CI is in place

louisabraham commented 4 years ago

Yes, the current code is formatted in black. I have never used Travis for linting or code formatting.

seanlaw commented 4 years ago

Neither have I but I can only assume that it must be possible. I currently perform linting/code formatting checks on Azure Pipelines before accepting any public PR. While it is possible to automate it, I haven't gotten to that level yet. Usually, the check is sufficient to highlight red flags

louisabraham commented 4 years ago

It is now done on travis. I also added code coverage reports as a bonus

Coverage