Sites chooser doesn't work in Chrome Incognito mode (& firefox)

louisbarclay / nudge

Nudge makes the internet less addictive.

https://nudgeware.io

MIT License

144 stars 9 forks source link

Sites chooser doesn't work in Chrome Incognito mode (& firefox) #70

Closed aadilayub closed 4 years ago

aadilayub commented 4 years ago

I just got the new update (the one that added the youtube autoplay blocker and ability to add intentions), and it removed all the sites I had previously added to Nudge.

I casually went back to the Nudge settings page to re-add my sites, but found that the text input field for adding sites isn't working. Like, I would type twitter.com, press Enter, and nothing would him.

Peeking into the console, I found this error firing every time I tried to add a site:

aadilayub commented 4 years ago

My bad, this may have been caused by me trying to edit the settings from incognito mode. Restarting the browser fixed the issue.

aadilayub commented 4 years ago

Reopening this issue since it appeared while testing in Firefox, and still appears when I accidentally open the extension in incognito mode in Chrome.

In my opinion, the extension should not break when enabled in incognito mode, and other users will expect this as well.

louisbarclay commented 4 years ago

Acknowledging this and will work on it as part of work on #73.

louisbarclay commented 4 years ago

As per #73 could you let me know if you are still experiencing this bug?

louisbarclay commented 4 years ago

Closing this as a duplicate of #73/because I am not sure if it is an issue any longer (I have changed Nudge's Incognito behaviour).