Nudge settings reset

[aadilayub]

Over the past few weeks, I've noticed Nudge randomly stops nudging the sites in my list. This has happened a few times. When I go and check the extension settings, I find that the "Choose your Nudge Sites" list is empty.

Maybe the list is being reset every time the extension receives an update?

[aadilayub]

Update: I checked the settings again and it seems all the features turned off, not just the nudged sites list

[aadilayub]

Update: this is happening quite frequently; every other day I think. In addition, I am getting the TypeError in the sites chooser mentioned in #70

[louisbarclay]

This is really bad. Sorry. Going to look into it in the next week or so, and generally revamp the way settings work so this kind of thing can't happen.

[aadilayub]

@lgwb89 no worries. Looking forward to the revamp! Let me know if there's any way to help out

[louisbarclay]

It looks like this is an issue that's been affecting quite a few users. I still haven't managed to reproduce. Working on it.

[louisbarclay]

I've released an update where settings are (hopefully) managed better and more simply. Also, it includes a migration of settings format to a new format so that any bugs in users' settings (e.g. type issues) are got rid of. @aadilayub can you please let me know if you are still experiencing this bug? If not, I recommend we close this.

[louisbarclay]

Update: I've been reported that this bug still exists. I'm screensharing later today with someone who has it (since I've never been able to reproduce), and hope I'll be able to sort it out finally.

@aadilayub if you are able to get any more evidence/logs for this, would be greatly appreciated.

[aadilayub]

@lgwb89 I'll try out the new update on a fresh browser profile tomorrow and report back. :crossed_fingers:

[aadilayub]

I can confirm that the bug still exists. Experienced it on both Brave and Chromium today (sites list was empty, all features had been turned off). I don't know how to provide evidence/logs for it since its hard to tell when the settings reset occurs.

However, I did notice this error in the console on the sites chooser screen

Uncaught (in promise) ReferenceError: runSites is not defined
    at option.js:184

[louisbarclay]

Thanks a lot. I think it might be because the order of the JS files on sites.html is bad. option.js precedes sites.js which has the runSites function in it. I'd be interested in your opinion of this diagnosis. I'm releasing a fix to change this - should arrive in a couple of days, and it's on GitHub already - so let's see if the problem still happens after that.

Couple of questions:

• Was it just the sites that reset, or all your settings?
• When you go to a site that you know you are currently nudging, does a nudge happen? In other words - are sites really reset to nothing, or is it just this page loading badly? You can also test this by entering await loadSettingsRequest() into the console, hitting enter and seeing if sites appear there in your settings

[louisbarclay]

Ah sorry - I just noticed when you said 'all features had been turned off'. Got it.

[aadilayub]

Happened again today on Brave. This time, all the other settings were active but the sites list had been cleared.

Got the same error as before:

Uncaught (in promise) ReferenceError: runSites is not defined
    at option.js:184

Running await loadSettingsRequest() in the sites chooser outputs this:

{daily_goal: false, dev: false, div_hider: false, fb_auto_unfollow: false, fb_grey: false, …}
daily_goal: false
dev: false
div_hider: false
fb_auto_unfollow: false
fb_grey: false
fb_hide_notifications: false
fb_profile_ratio: false
get_stickier: false
install_date: false
last_seen_day: "2020-05-02"
nudge_domains: []
off_by_default: false
on_domains: []
paid: false
schedule: false
scroll_nudge: false
settings_version: 2
share_data: true
snooze: {all: 0}
stop_autoplay: false
time_nudge: false
unhidden_hidees: []
userId: "c2d9e7a6e67aa5ebef942a92c911b75dd01553332f3583ce514f51257b303264"
whitelist_domains: []
__proto__: Object

In this screenshot you can see the result of inspecting the background page, as well as the result of await loadSettings()

[louisbarclay]

OK - this is really helpful. I think it might be caused by everySecond running before the rest of the app has initialised, which somehow sets last_seen_day and overrides all other settings. Working on it now.

[louisbarclay]

I've released the fix to this. Should arrive on Web Store by end of this week. More information on my diagnosis of the bug below.

• settings are loaded async initially
• There is a slight delay here
• settingsLocal is set, properly
• Before settingsLocal has been set a setting is changed
  • because of the slight delay
  • last_seen_day is set by everySecond
  • the settings change uses settingsLocal, which happens to still be empty
  • Therefore settings are overridden
  • Specifically, the Chrome sync settings are gone
    • But settingsLocal is still fine, because you have a correct copy of those

[louisbarclay]

Has anyone experienced this bug in the latest release, which is 1.0.65? You can check Nudge version number like this:

• Right-click on Nudge icon
• Manage extensions
• Version is at the top

Let me know if you have/do.

[aadilayub]

Haven't experienced the bug on this new release. I'd give it a few more days to make sure, though.

[louisbarclay]

Thank you for the update.

[louisbarclay]

I'm closing this ticket since I'm pretty sure the problem is gone.