louischan / simplewhite

A minimal theme for Mozilla Firefox.
https://addons.mozilla.org/addon/simplewhite/
Mozilla Public License 2.0
77 stars 20 forks source link

Simple White breaks Reader Mode (Nightly v39) #28

Open alexsereno opened 9 years ago

alexsereno commented 9 years ago

Simple white seems to break Reader Mode, a feature added in nightly.

Reader mode is, in essence, Readability built in to Firefox.

Simple white breaks it. Ex: Broken about:reader page Ex: Working about:reader page Ex: Page rendered in Reader mode

As shown, simple white breaks the about:reader page / process used to render. Additionally, the "reader mode" button is not displayed but clicking that region on an applicable page starts a broken version of reader mode.

This is a confirmed new feature but obviously since it's in nightly won't be landing for awhile and thus doesn't require immediate action.

lychichem commented 9 years ago

In fact, I've tested reader mode on my firefox nightly. Now it's hard to use. Maybe it will take some time for site managers to fit this mode.

Snow8 commented 9 years ago

Same issue in Firefox Dev Channel that currently stands at version 39.

lychichem commented 9 years ago

please use developer edition of this theme

Snow8 commented 9 years ago

I tried the Dev edition of this theme... does not fix the problem.

lychichem commented 9 years ago

There is no problem on windows, maybe a specific problem on Mac.

Snow8 commented 9 years ago

I am on Windows. I know this features works without the theme and not with the theme. All I am saying!

lychichem commented 9 years ago

well, on nightly 40 and the theme enabled, there is no problem. Maybe you can try nightly 40

Snow8 commented 9 years ago

I am not here to "bug test" or change my browser for a dev theme to work. Simply reporting that Firefox Reader is not working with this theme in Firefox Dev Edition.

louischan commented 9 years ago

I am aware of this issue. New interfaces in Firefox usually change rapidly in Nightly or Dev Edition (Aurora). They will become stable after 2-3 stable releases. Keeping up with all the changes is quite challenging, but I will fix this asap. Thanks for your patience.

Snow8 commented 9 years ago

Thank you for the info. Dont worry too much about it. I am aware that I am not on a stable channel but simply wanted to point it out so it might be ready for the future.