search

louischan / simplewhite

A minimal theme for Mozilla Firefox.
https://addons.mozilla.org/addon/simplewhite/
Mozilla Public License 2.0
77 stars 20 forks source link

Tabs size increase when Noise Control icon is present #34

Closed SW1FT closed 7 years ago

SW1FT commented 9 years ago

I've been using an addon called Noise Control which adds an icon on tabs that have HTML/Flash audio. When it detects audio and adds the icon it increases all tabs size which isn't intended and only happens with the Simple White theme enabled. This is very annoying because when you pause/unpause something that has audio on it, it will change the size of the tabs accordingly.

Noise Control didn't detect audio: noise control off

Noise Control detected audio: noise control on

As you can see, on the second image, the tabs are a bit taller.

louischan commented 9 years ago

It can be fixed using:

svg[anonid="noise-indicator"] {
  margin: 1px 0 -1px;
}

I'm not sure whether enforcing tab height is a good idea because this may affect users using a larger UI font. Default theme doesn't set the height attribute either.

SW1FT commented 9 years ago

I agree. As I'm not very familiar with CSS, I didn't know how to enforce height on that particular icon.