louischan / simplewhite

A minimal theme for Mozilla Firefox.
https://addons.mozilla.org/addon/simplewhite/
Mozilla Public License 2.0
77 stars 20 forks source link

Firefox 40.0a2 broke about:addons #41

Open SW1FT opened 9 years ago

SW1FT commented 9 years ago

simple white bugged ff 40

As seen in this screenshot, Firefox 40.0a2 broke some stuff in about:addons: 1) Some of the icons (Addons, Appearence, Dictionaries) on the sidebar of the Addon Manager are not the Simple White ones; This has been fixed by Mozilla as of Firefox 40.0a2 (2015-06-12), so it wasn't a problem with Simple White.

2) The header (which includes the search bar and options icon) is "inside" the view-port (introduced by the update) when it should be outside and not affected by main-content styling (borders etc...). I've fixed this in #39 and #40.

johngraciliano commented 9 years ago

The code at the end of this post fixes the problem. It can be used with Stylish. I tested it to work with Firefox versions 39 through 43. (I should have tested 38ESR, anybody please do!) I will be adding this and other corrections where it belongs in my fork at some moment in time:

@-moz-document url("about:addons") { keyset + hbox:not(#header){ padding-top: 43px; } .main-content{ position: relative; } .main-content #header{ position: absolute; right: -1px; top: -44px; } }

SW1FT commented 9 years ago

But that fix isn't a fix per say, it's a workaround. I've made the fix a long time ago, it is still on the pending pull request list (see https://github.com/louischan/simplewhite/pull/39 and https://github.com/louischan/simplewhite/pull/40).

johngraciliano commented 9 years ago

Thank you SW1FT. Your solution is certainly more elegant than mine. I hope you do not object I assimilated your update with some changes into my fork. I like using my own condiments. In particular, I avoided changing inContentUI.css because it resides in the global directory, which hints it may be used elsewhere. Yet that file may end up being zombie code since I did not find it in Aurora 42.0a2!

SW1FT commented 9 years ago

No problem. Also, I'm not using this theme anymore unless the developer becomes active and updates the theme more regularly so I might not come back to this fork.