louischan / simplewhite

A minimal theme for Mozilla Firefox.
https://addons.mozilla.org/addon/simplewhite/
Mozilla Public License 2.0
77 stars 20 forks source link

Theme breaks the close, maximize, and minimize buttons. #49

Open ubergeek77 opened 9 years ago

ubergeek77 commented 9 years ago

This is happening with Firefox v40.0 stable on Windows 10. While there is already an open issue similar to this one regarding the top bar not being aligned properly, and even though I can confirm that this is happening for me as well, that issue does not specifically address the top three buttons being broken. This did not happen on Firefox 39.0, and only started happening after Firefox auto-updated to 40.0. The default theme, as well as a few other 40.0-compatible complete themes from the Mozilla add-on website, do not have this issue of breaking the close, maximize, and minimize buttons.

bwoodruff commented 9 years ago

Can confirm -- also having this issue.

FrancescoScarlassare commented 9 years ago

Those fixes do not work. Causes buttons to completely disappear. is there a way to not use the theme's Window Control Buttons (thus using the default Windows ones)?

Lootyhoof commented 9 years ago

Works for me, on both Firefox 40.0.3 and Firefox Dev Edition 42.0a2.

Themed Firefox

Have you tried with a clean profile?

FrancescoScarlassare commented 9 years ago

I did not try that. Am I supposed to just replace browser-common.css in the XPI file and re-zip? Is there a particular way to zip it using 7zip?

Lootyhoof commented 9 years ago

You'd need to replace browser-common.css, and add in caption-buttons.svg. I've pushed a .xpi out here, for a quick fix. Nothing else in it was changed other than the Win10 fixes.

FrancescoScarlassare commented 9 years ago

That worked. Thank you.