search

louischan / simplewhite

A minimal theme for Mozilla Firefox.
https://addons.mozilla.org/addon/simplewhite/
Mozilla Public License 2.0
77 stars 20 forks source link

Addon icons not scaling correctly #53

Open teknetia opened 9 years ago

teknetia commented 9 years ago

When I enable Simply White I get these issues with the 1Password and Honey plugins where the icon scales up. In the case of Honey it can become 4x the size of the original!

screen shot 2015-09-07 at 20 44 39
johngraciliano commented 9 years ago

By chance, I tested and found that one of my changes fixes the problem for Honey's icon. I did not verify if it also fixes the problem for the 1Password icon because I could not find it in A.M.O. However I already noticed my update resized Chatzilla's icon when it is in the "Additional Tools and Features" in the customize screen. The updated file, browser-common.css, is the result of merging with code from a much newer browser.css. I did this in an attempt to catch corrections such as this but I needed to test for no ill side effects (initially there were a lot!). Now I can confirm the effort was worth. LouisChan appears to be very busy or otherwise unable to update this theme as fast as some of us would like. For that reason I am working on updating it in a fork of my own. I am trying to update Simple White to have it as look as it was before the update to Firefox 40. That update broke more than one thing in the theme and a few more are to be broken once Firefox 41 comes out in a few weeks.* I am trying to have my version ready for that. Any help (especially testing) is welcome.

*I also got corrections that were already posted by Lootyhoof. **The problem you found is not present for Firefox 38 or 39. My update fixes the problem for Firefox 40 and 41 (without breaking earlier versions) but I checked it did not work for the latest Nightly 43.0a1.