search

louisdh / openterm

OpenTerm, a sandboxed command line interface for iOS
Other
1.63k stars 249 forks source link

Standardize Indentation rules #54

Closed ian-mcdowell closed 6 years ago

ian-mcdowell commented 6 years ago

Currently, both tabs & spaces are littered across the code. It'd be nice to set a standard and set project-wide Xcode settings for indentation, and add SwiftLint rules.

louisdh commented 6 years ago

I'm in favor of tabs, fwiw.

louisdh commented 6 years ago

Also: if indentation is standardized for OpenTerm, I think it should only apply to the app. ios_system shouldn't need to change its indentation to match OpenTerm.

mecid commented 6 years ago

@louisdh we can exclude ios_system folder from SwiftLint.

louisdh commented 6 years ago

I will add SwiftLint once #62 and #63 have been merged (to avoid further conflicts).

louisdh commented 6 years ago

Added Swiftlint in 0f5a1c426debf8ab47ad303bdca9b2600c29ab7e

louisdh commented 6 years ago

I've set the project setting for indentation to use tabs 952270e511c49d928ecdc190b72c31f4498f7852.