louisdh / openterm

OpenTerm, a sandboxed command line interface for iOS
Other
1.63k stars 249 forks source link

Handle files with spaces better #74

Open louisdh opened 6 years ago

louisdh commented 6 years ago

Currently you can't redirect an output to a file with spaces in its name. E.g. the following doesn't work:

echo hello > "Hello world.txt"

Auto complete also doesn't account for spaces in files, so it will suggest adding file names with spaces in it, which then leads to unexpected actions for the user.

Ideally we would also support a backslash for escaping spaces. Such that the following 2 are equivalent:

echo hello > "Hello world.txt"
echo hello > Hello\ world.txt
louisdh commented 6 years ago

This probably needs changes to ios_system @holzschu.

holzschu commented 6 years ago

Ah, yes. I see where the problem is and how to solve it, at least for the first one. Could you add an issue over there?

alessaba commented 6 years ago

I know there are many things to do right now for OpenTerm 2, but i think this bug is pretty important and it'd be good if it was solved before 2.0 release

holzschu commented 6 years ago

I think it's been solved: https://github.com/holzschu/ios_system/issues/18

alessaba commented 6 years ago

I think it was solved in ios_system but not correctly implemented in openTerm. The bug persists on my devices, so i assume it's not solved

Filippo Claudi

Il giorno 28 apr 2018, alle ore 20:33, Nicolas Holzschuch notifications@github.com ha scritto:

I think it's been solved: holzschu/ios_system#18

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

alessaba commented 6 years ago

It now works for me :-)