search

louisdh / textor

A plain text editor for iOS
MIT License
585 stars 113 forks source link

Support for multiple tabs. #16

Closed iosdevzone closed 6 years ago

iosdevzone commented 6 years ago

Not sure if you're interested in this. Adds a little more complexity to the code...

This pull request adds the ability to have multiple tabs open in textor. The behavior is controller by a user default setting which is disable by default (just in case it breaks something)!

The implementation abuses UIDocumentBrowserViewController somewhat, for more information see the comments in TabbedDocumentViewController.swift.

louisdh commented 6 years ago

Nice proof of concept! Unfortunately UIDocumentBrowserViewController isn't currently built for this kind of thing. There are some UI glitches, and some cases that would need special handling (such as opening the same document in two tabs). Also, the plus button for a new tab might confuse users with the plus button in the initial UIDocumentBrowserViewController (which creates a new document).

The good news is that there are some rumors about Apple adding tab support for document based apps. So when they do, we'll have a reliable, native, way of adding tabs to Textor. Until then, Textor won't support tabs. I hope you understand.

iosdevzone commented 6 years ago

No worries. Just thought I'd make you aware of the proof-of-concept.