Allowed console commands can be easily bypassed

[AlexPewMaster]

⚠️ Please verify that this bug has NOT been reported before.

• [X] I checked and didn't find similar issue

🛡️ Security Policy

• [X] I agree to have read this project Security Policy

Description

Hi, I've recently discovered that the allowed console commands can be easily bypassed. The current allowed console commands are docker, ls, cd and dir. However, these can be easily bypassed by adding && <YOUR OTHER COMMAND> after one of the allowed commands. For example, if I want to run history, I could easily execute ls && history. In my eyes, this could be a potential security risk.

👟 Reproduction steps

1. Go to the Dockge dashboard (standard landing page)
2. Click on "Console" at the top-right
3. Enter an allowed console command and add && YOUR_COMMAND, replacing YOUR_COMMAND with the command you wish to execute. For example: ls && history
4. See successful execution.

👀 Expected behavior

The command after && should be rejected.

😓 Actual Behavior

The command after && gets executed successfully.

Dockge Version

1.4.2

💻 Operating System and Arch

Fedora Linux 39 arm64

🌐 Browser

LibreWolf 124.0.1-1

🐋 Docker Version

Docker 26.0.0

🟩 NodeJS Version

No response

📝 Relevant log output

root@f8d00b415b7a:/opt/stacks# cd . && echo "This shouldn't work"
This shouldn't work
root@f8d00b415b7a:/opt/stacks#

[dswd]

There are many of such patterns:

• ls ; history
• ls DOESNOTEXIST || history
• ls $(history >&2)
• ls `history >&2`

There surely exist many more.

[truthsword]

Obviously I don't understand this constraint. I've found this “feature” helpful. What is the security concern beyond the container?

[dswd]

Obviously I don't understand this constraint. I've found this “feature” helpful. What is the security concern beyond the container?

The Dockge container needs access to the docker daemon of the host in order to work. If you can control docker, you can control the host (you can mount any path you want and use it with root permissions). So any security issue in this container like the reported one automatically affects the host as well.

[truthsword]

Thanks. I “assumed” this was the same as running the bash terminal on the managed containers.

[eliaspizarro]

suggest allow any command and add disable bash option.

[LorneCash]

PLEASE DON'T FIX THIS until you add a way to authenticate with at least with Docker Hub (to avoid the rate limit when updating containers). I was able to use this "exploit" to authenticate. For me personally I'd just say remove the limitation all together, but I understand why some people would want it. Please consider adding a configuration option to allow unrestricted access for those of us that this security issue is not a concern for.

On a side note I'm not really sure why this command was not allowed since it is a docker command: docker login -u your-username -p your-password