louislam / uptime-kuma-wiki

MIT License
50 stars 75 forks source link

Potential Small Typo in How-to-Update.md #60

Closed craigpryde closed 7 months ago

craigpryde commented 9 months ago

Hey @louislam,

Love the tool, Just wanted to check on the How-to-Update.md, The commands for docker compose are listed as docker compose over docker-compose (Without the '-'). Im still fairly new to docker so i might be wrong but i think it need's to include the - to work with the standard docker-compose install.

Wanted to check as this might be easiest for yourself to fix over myself submitting a PR onto the pile.

Cheers Craig

louislam commented 9 months ago

When I learnt docker compose, the command is docker-compose. And it is a standalone tool, people have to install separately.

Maybe they now integrated this into the docker? If yes, we can change it to docker compose.

craigpryde commented 9 months ago

Hey @louislam, I think my initial message was unclear. It's currently docker compose in your How-to-Update.md It should be docker-compose as we both mentioned due to it being a stand alone tool.

here's the file i'm referencing: https://github.com/louislam/uptime-kuma-wiki/blob/master/%F0%9F%86%99-How-to-Update.md#docker-compose

Sorry for any confusion.

louislam commented 9 months ago

Oh, I got it now, these commands in the wiki are written by another contributor. I didn't notice that is already in docker compose until now.

I just checked:

docker-compose = V1 docker compose = V2

V1 is actually deprecated, V2 is recommended by Docker official.

Install V2 plugin: https://docs.docker.com/compose/install/linux/