search

louislam / uptime-kuma

A fancy self-hosted monitoring tool
https://uptime.kuma.pet
MIT License
52.54k stars 4.73k forks source link

Custom Timezone: UTC (no DST) #1602

Open JacksonChen666 opened 2 years ago

JacksonChen666 commented 2 years ago

⚠️ Please verify that this feature request has NOT been suggested before.

🏷️ Feature Request Type

UI Feature

🔖 Feature description

A timezone that is based off of UTC+00:00 and does not use DST does not exist, and I think it should be added for convenience sake (for those who want to use UTC)

✔️ Solution

Add a custom timezone that is called UTC that is based off of UTC+00:00 and does not have DST.

❓ Alternatives

Using the Africa/Abidjan timezone (should be the equivalent)

📝 Additional Context

I personally prefer over having UTC and then doing my own timezone addition in my head, and do it that way pretty much for other things too (like my website). I was looking for an option for UTC, but couldn't find one.

CommanderStorm commented 1 year ago

There is no advantage to this feature request, right?

I think this should be left as is image

JacksonChen666 commented 1 year ago

feature request is about adding UTC so people who want UTC can easily choose UTC instead of having to go through many hoops to find something that is similar to UTC

CommanderStorm commented 1 year ago

So basically you want UTC+00 which is here: image

CommanderStorm commented 1 year ago

Note that having an extra selection for UTC would be worse, given that we have changed the display of messages to include the timezone marker if an embed is present. See https://github.com/louislam/uptime-kuma/issues/3153 for more details

JacksonChen666 commented 1 year ago

So basically you want UTC+00 which is here:

Yes but it's not as clear cut as "choose one and it is UTC". Scoresbysund (now known as Ittoqqortoormiit) is not UTC because it has DST (https://time.is/Ittoqqortoormiit) and UTC does not have DST.

CommanderStorm commented 1 year ago

DST is not supported upstream. Unless we switch to a different library or dayjs supports this one day, this will not be a feature.

See https://day.js.org/docs/en/manipulate/utc-offset#docsNav See also https://github.com/iamkun/dayjs/issues/1437

Here is upstream: https://github.com/iamkun/dayjs/blob/dev/src/plugin/timezone/index.js Here is our clone: https://github.com/louislam/uptime-kuma/tree/master/src/modules/dayjs/plugin/timezone