search

louislam / uptime-kuma

A fancy self-hosted monitoring tool
https://uptime.kuma.pet
MIT License
55.47k stars 4.99k forks source link

An Atom (RSS) feed for notifications (including the public) #1673

Closed JacksonChen666 closed 4 days ago

JacksonChen666 commented 2 years ago

⚠️ Please verify that this feature request has NOT been suggested before.

🏷️ Feature Request Type

New Notification

🔖 Feature description

Add RSS/Atom feeds as a way of notifications.

✔️ Solution

Add a new notification method (RSS/Atom feeds).

Also, add an option of which feed should correspond to a status page on when modifying the status page.

❓ Alternatives

No response

📝 Additional Context

Some examples of real world use:

Rhaal commented 1 year ago

@louislam , quick question! Would you be willing to consider merging a PR for this issue if one was available ?

JacksonChen666 commented 1 year ago

@louislam , quick question! Would you be willing to consider merging a PR for this issue if one was available ?

@Rhaal this does not feel like a necessary question, except for the case for if the maintainer is OK with a feature like that.

there also seems to be a lot of positive reactions/support on my issue, so at least some people are likely looking for this feature.

i suggest that you start working on it, create a draft PR, and include resolves #1673 somewhere in the description so that merging the PR closes this issue and this issue links to that PR (feature doc).

Rhaal commented 1 year ago

@JacksonChen666, makes perfect sense! Thanks for the pointers, I had tagged Louis simply to get a suggestion on how I could help on the subject at hand - and I'd say your proposal is the best course of action, in the worst case it's just a draft PR to discard. Thanks!

louislam commented 1 year ago

Yes, better discuss before work, Uptime Kuma's pull request rules: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

I usually accept notification pull requests, but how RSS could be a notification type in Uptime Kuma? It is because for most current notification providers such as Telegram, it makes a request to Telegram API in order to send a notification. However, RSS is just a xml, it doesn't seem to be a notification type in my opinion.

JacksonChen666 commented 1 year ago

@louislam RSS feeds are more of a "pull" model (client periodically pulls information), and the current notification in uptime kuma is more of a "push" model (server sends a notification which is pushed to the client).

i think i'm starting to see this idea fall apart.

however, instatus provides an RSS/Atom feed, and i have added sponsorblock status to my RSS feeds.

Rhaal commented 1 year ago

Hi everyone - absolutely agreed, and thanks for taking the time to point me to the Contribution guidelines - I really should have read them beforehand! I've opened the PR for discussion, and I do acknowledge your concerns are super-valid; however I'd say RSS is just another kind of view apart from HTML, used by clients that conveniently have periodic polling built within them. If you both agree I'd move the discussion on the feasibility to the draft PR as to not pollute the issue.