louislam / uptime-kuma

A fancy self-hosted monitoring tool
https://uptime.kuma.pet
MIT License
55.07k stars 4.95k forks source link

[Steam game server] should not mark service down if Steam API is down #2446

Open gegtor opened 1 year ago

gegtor commented 1 year ago

⚠️ Please verify that this bug has NOT been raised before.

🛡️ Security Policy

Description

I monitor around 25+ game servers and when steam api goes for whatever reason (for example on Tuesdays when Steam has routine maintenance) all servers are marked down and produce incredible notification spam both when going down and up

And just like that every Tuesday my phone explodes with 50+ notifications while everything is working

👟 Reproduction steps

Monitor any steam game server and wait for Steam API to error out with code 502 or any other

👀 Expected behavior

When Uptime Kuma can't check actual status of the service it should not mark the service down

Possible solutions are:

😓 Actual Behavior

When Steam API goes down all services are marked down producing notification spam when actually all services are up

🐻 Uptime-Kuma Version

1.18.5

💻 Operating System and Arch

Uptime Kuma official Docker image

🌐 Browser

Safari 13

🐋 Docker Version

No response

🟩 NodeJS Version

No response

📝 Relevant log output

Monitor Request failed with status code 502
rezzorix commented 1 year ago

Why would you mark this as a bug?

The only way to reliably check a server (online) status is the steam api and the monitor relies on it.

If the api is down, then the monitor has no way to know and it will report your game as down.

Turn this logic around and make the monitor stay online if api is offline, then you will have people reporting the opposite as a bug.

Alternatively you could write a script that checks the gameserver process if running or not and call a pushmonitor.

However, I would remove the bug-tag here; maybe a feature-request for a switch to define what happens if api is down.

gegtor commented 1 year ago

Why would you mark this as a bug?

The only way to reliably check a server (online) status is the steam api and the monitor relies on it.

If the api is down, then the monitor has no way to know and it will report your game as down.

Turn this logic around and make the monitor stay online if api is offline, then you will have people reporting the opposite as a bug.

Alternatively you could write a script that checks the gameserver process if running or not and call a pushmonitor.

However, I would remove the bug-tag here; maybe a feature-request for a switch to define what happens if api is down.

A switch bellow Steam API token input would be nice 2 options: