louislam / uptime-kuma

A fancy self-hosted monitoring tool
https://uptime.kuma.pet
MIT License
55.73k stars 5.01k forks source link

UI labels in DNS monitors are misleading #2963

Open gabrielwhite opened 1 year ago

gabrielwhite commented 1 year ago

⚠️ Please verify that this bug has NOT been raised before.

🛡️ Security Policy

Description

The headings above the response times for DNS monitors say "Ping" and "Avg. Ping".

I suggest these heading be changed to "Response" and "Avg. Response". I got confused when looking at the monitor thinking it was doing a ping before I realised it was doing DNS checks.

Screenshot 2023-03-22 at 2 32 24 pm

👟 Reproduction steps

Set up DNS monitor.

👀 Expected behavior

Different field labels.

😓 Actual Behavior

Misleading field labels.

🐻 Uptime-Kuma Version

1.21.0

💻 Operating System and Arch

official docker

🌐 Browser

any

🐋 Docker Version

na

🟩 NodeJS Version

na

📝 Relevant log output

No response

rezzorix commented 1 year ago

This is not a bug.

This is terminology which might not be 100% accurate but applying common sense it should be clear rather than confusing you 😉

If you like to contribute I suggest you change the code wherever applicable and make a pull request.