louislam / uptime-kuma

A fancy self-hosted monitoring tool
https://uptime.kuma.pet
MIT License
59.5k stars 5.33k forks source link

[Discord] Service URL should only be included if defined #3327

Open OnCloud125252 opened 1 year ago

OnCloud125252 commented 1 year ago

⚠️ Please verify that this bug has NOT been raised before.

πŸ›‘οΈ Security Policy

Description

This is what I received from the Discord notification webhook when one of the child services of a group I created went down. It display a section Service URL with a value https://. I don't think this section is necessary since it's a group and there's no related configuration in the settings.

Screenshot_2023-06-28-16-07-47-14_572064f74bd5f9fa804b05334aa4f912


The similar situation happened when the service is up. The section Service URL display https://. And the Ping section display N/A.

Screenshot_2023-06-28-16-29-26-92_572064f74bd5f9fa804b05334aa4f912

πŸ‘Ÿ Reproduction steps

Set up a Discord notification and enable it in a group.

πŸ‘€ Expected behavior

πŸ˜“ Actual Behavior

The notification display unnecessary informations.

🐻 Uptime-Kuma Version

1.22.0

πŸ’» Operating System and Arch

Ubuntu 22.04.2

🌐 Browser

No browser, it happens in Discord.

πŸ‹ Docker Version

No response

🟩 NodeJS Version

16.20.1

πŸ“ Relevant log output

No response

CommanderStorm commented 1 year ago

what kind of monitor are you using? Could this be another symptom of the issue discussed in https://github.com/louislam/uptime-kuma/issues/3274

OnCloud125252 commented 1 year ago

@CommanderStorm

  1. In the latest release (1.22.0) there's a new monitor type named Group and it is supposed to monitor the child monitors, not the URL. So there shouldn't be a section named Service URL in the notification.
  2. I've seen that issue, I believe that my issue is different from the one you provided.