louislam / uptime-kuma

A fancy self-hosted monitoring tool
https://uptime.kuma.pet
MIT License
59.9k stars 5.36k forks source link

Support timezone in notifications #40

Closed ksurl closed 2 years ago

ksurl commented 3 years ago

apk add tzdata to docker image and support TZ environment variable to set the timezone. alpine is pretty straightforward. you just add this to the start up before running the app

cp -f "/usr/share/zoneinfo/${TZ}" /etc/localtime && echo "${TZ}" > /etc/timezone.

I would suggest a script to run the cp and the npm startup and set the script as the entrypoint

louislam commented 3 years ago

Timezone is already handled in the frontend and you can change in the "Settings" page. All dates stored in SQLite are in UTC.

ksurl commented 3 years ago

The discord notification uses utc time

image

rezzorix commented 3 years ago

Interesting.

Just realized that for Discord notifications the time of incident is sent. In Telegram notifications just give information on that status - without any time...

@louislam maybe would be good to either streamline notification texts on backend for each service OR (maybe even better) let users customise the notification text (including setting a timezone for this notifications)

I really would contribute more than only writing enhancements and testing builds but my coding skill are far too limited ... :pensive:

Simon-Peham commented 3 years ago

The same is in the Slack notifications it is also in UTC

tgxn commented 3 years ago

Same for all the notifications I think; they are all UTC. I'd like for them to follow the instance timezone, if configured (if it's "Auto" or not configured we can consider it to be UTC, as we can't infer the client data from the server)

Instance Timezone:
image

kamilmirza commented 3 years ago

same problem with Pushover notifications configured desired UTC but no go in Settings Screenshot_20210920-204404535

chris-ard commented 3 years ago

Yeah, having the same issue over Slack. Loving Uptime Kuma so far - awesome polish. However, for us to use in production the timezone really needs to be considered in the message (or have it customizable).

For example, we have clients in US, parts of EU, and Australia. The timestamp from Slack takes a lot of figuring out because it will only show us time here. It's also bit confusing as well that it doesn't match relative to the time within slack.

MostHated commented 2 years ago

It would definitely be nice to have all times used within the system to use the proper timezone. While the interface has the right time by setting the timezone, that doesn't really do anything for me, as I don't often look at the interface. I am attempting to pull the data from "api/status-page/heartbeat" to use in various automations.

windware-ono commented 2 years ago

Hello. I'd like the fix implemented. This should be a quick fix.

FrancisHG commented 2 years ago

++ Same, I am using Slack and it is using UTC for text notification, not the configured timezone in UptimeKuma.

pbunluesin commented 2 years ago

I got this issue with Line Notification. it's effect with production which need accurate time.

drtech981 commented 2 years ago

Bump, still having this issue. It is messing up with quick fixes since some of my clients are around -13 hrs behind our timezone. Already have set TZ in uptime-kuma as well as on the ubuntu machine.

BeyondVertical commented 2 years ago

Same problem here with mails. Would be great if this is fixed. I have docker running and have /etc/timezone in the container via volumes. It is set there correct, but not right in the logs and the pushes.

stavros-k commented 2 years ago

I don't think +1 ing this does not provide any help. Since it's still open, it's an issue. Use the "reactions" on the top post to show you "want" this implemented. Keeps the chat clean and will be easier for contributors to discuss how that would be implemented.

Also reduces the notification "spam" with useless comments to everyone subscribed on this issue.

mbacicc commented 2 years ago

I'm also having timezone problems with email notification.

It would be easily solved by installing tzdata in the base image (both debian and alpine have this package) and passing the TZ env var in the docker container.

yyahari commented 2 years ago

Como solucion a este error en particular con respecto a smtp hicimos uunas modificaciones, 1.apt update && apt install tzdata -y 2.dpkg-reconfigure tzdata 3.Seleccione mi time zone correspondiente 4.corri "date" dandome la fecha y hora de mi zona horaria 5.edite el archivo /app/server/notification-providers/smtp.js 6.comente el campo: //if (heartbeatJSON) { // bodyTextContent = ${msg}\nTime (UTC): ${heartbeatJSON["time"]}; // }

  1. agregue; let fecha = new Date(); let fechayhora=fecha.toLocaleString();

    if (heartbeatJSON) {
        bodyTextContent = `${msg}\nTime: ${fechayhora}`;
    }
  2. con eso me muestra la hora correcta con respecto a mi pais en los correos 9.Saludos
Dr0id1 commented 2 years ago

Do we have an update on that ?

BeyondVertical commented 2 years ago

Do we have an update on that ?

Don't think so. Would be nice to have this feature soon. :)

louislam commented 2 years ago

I recently added server side timezone along with the maintenance pull request. It is configurable in the Settings page.

LOUIS-AORUS-15P  006095

It is an example of convertion of utc to server timezone.

dayjs.utc(myDate).local().foarmt(<DATE FORMAT>)
BeyondVertical commented 2 years ago

Awesome. When can we get it in the releases? 😂

roughnecks commented 1 week ago

Sorry if I'm posting here, but I think this issue is still current with webhooks notifications.

image

image

CommanderStorm commented 1 week ago

What is your notification template?

roughnecks commented 1 week ago

"template": "${heartbeat.time}\r\n${msg}"

CommanderStorm commented 1 week ago

time is in UTC. If you want the local time, please use localDateTime instead. If you want the Timezone in addition, you can use timezone

We know that the documetation surroudning the templating system is quite confusing but have not yet have the time to improve this part

roughnecks commented 1 week ago

I see, will make the change. Thanks