search

louislam / uptime-kuma

A fancy self-hosted monitoring tool
https://uptime.kuma.pet
MIT License
53.27k stars 4.81k forks source link

GameDig 5.x Support #4414

Open scarecr0w12 opened 6 months ago

scarecr0w12 commented 6 months ago

⚠️ Please verify that this feature request has NOT been suggested before.

🏷️ Feature Request Type

Other

🔖 Feature description

Gamedig 5.0.0-beta.0 Support

✔️ Solution

Please update package to include GameDig 5 for additional supported games, specifically PalWorld (one of the largest games to release on steam )

❓ Alternatives

None

📝 Additional Context

No response

louislam commented 6 months ago

Feel free to ping here again if they have released 5.0.0 non beta.

scarecr0w12 commented 6 months ago

Feel free to ping here again if they have released 5.0.0 non beta.

I'll be keeping an eye on it. As a work around, i should be able to change the package.json myself to include it locally, correct?

louislam commented 6 months ago

Yes, and run npm install --production to download the package.

scarecr0w12 commented 6 months ago

hmm i guess the new version uses import function over require now, so code change would be needed.

CommanderStorm commented 6 months ago

Not the only breaking change:

  • Almost all games ids have been changed to follow a standard, see CONTRIBUTING.md#naming.
  • Removed minecraftping (as it was deprecated and the same thing as minecraft) and minecraftpe (deprecated, which is now the same as mbe (Minecraft Bedrock Edition)).
  • Removed the games.txt file, the games definitions are now stored in-code (exported on games).

=> adding a migration with the renamings would be nessesary

That this also bumps the minimum node version to v16. => includes part of https://github.com/louislam/uptime-kuma/pull/3747

FurkanVG commented 6 months ago

Came here by to see that i would love this, for Palworld of course. Since there is no other way to monitor a Pal Server, i would live this.

louislam commented 6 months ago

Not the only breaking change:

  • Almost all games ids have been changed to follow a standard, see CONTRIBUTING.md#naming.
  • Removed minecraftping (as it was deprecated and the same thing as minecraft) and minecraftpe (deprecated, which is now the same as mbe (Minecraft Bedrock Edition)).
  • Removed the games.txt file, the games definitions are now stored in-code (exported on games).

=> adding a migration with the renamings would be nessesary

That this also bumps the minimum node version to v16. => includes part of #3747

I think it is big enough to create a new monitor type for Gamedig 5.

CommanderStorm commented 6 months ago

Are you sure?

chakflying commented 6 months ago

I think for the end-user, it doesn't make sense to have another monitor type that basically does the same thing. But some work is definitely required to make the migration smooth.

dustyhansen commented 1 month ago

It looks like they released v 5.0 last month. Any more thought to implementing this so we can add some of the newer games?

CommanderStorm commented 1 month ago

If you are requesting guidance on how to implment this:

feel free to ping me if you have more questions ^^

dustyhansen commented 1 month ago

I was just letting you guys know that 5.0 was out of beta and hoping this would get some traction since gamedig hasn't been updated in 6 months+ and is missing a few games. I'm not a developer.

elonmir commented 1 week ago

/bump, missing Enshrouded... added in the 5.0.X Patch of Gamedig.

elonmir commented 1 week ago

Instead of just bumping I decided to do it myself... =)