search

louislam / uptime-kuma

A fancy self-hosted monitoring tool
https://uptime.kuma.pet
MIT License
53.28k stars 4.81k forks source link

[groups] pausing groups does show children as paused without pausing them #4696

Open Tealk opened 3 months ago

Tealk commented 3 months ago

📑 I have found these related issues/pull requests

🛡️ Security Policy

Description

If you pause the folder, the underlying elements are also displayed as paused, but notifications are still sent.

👟 Reproduction steps

Create a folder and a child element Add a notification to the child element Pause the folder create an error

👀 Expected behavior

no notification is sent because all elements are paused image

😓 Actual Behavior

notifications are sent image

🐻 Uptime-Kuma Version

1.23.12

💻 Operating System and Arch

Debian 12 (bookworm)

🌐 Browser

Firefox 125.0.1 (64-bit)

🖥️ Deployment Environment

📝 Relevant log output

No response

CommanderStorm commented 3 months ago
paused unpaused
image image

Could you provide a concrete example how to test this? Groups work mostly as expected in the experiment I ran.. Yes, they tick on (that is a bug) but they record all heartbeat as UP => no notifications

Tealk commented 3 months ago

Could you provide a concrete example how to test this?

I have indicated above how it can be reproduced, or what exactly is the question?

Or am I misunderstanding the pause function, I thought it would not be checked further and therefore no notification would be sent.

CommanderStorm commented 3 months ago

Please see my screenshots: I can't reproduce your steps... => need a concrete example how to test this

Tealk commented 3 months ago

as you can see in my screen i have 3 checks in one folder, i paused the folder because i restarted the server on which the 3 are running so that no notification comes.

But it was still checked and a notification was issued.

CommanderStorm commented 3 months ago

Okay, somehow my testing mechanism was a bit flawed. I re-tried reproducing it on https://uptime.kuma.pet/ monitoring https://beeceptor.com/ was able to do so.

Tealk commented 3 months ago

if there is anything I can do, please let me know

CommanderStorm commented 3 months ago

I would love to have a contributor debug this. I currently don't have the time to spend on that due to personal reasons (writing a bachelor thesis), but do have the time to review PRs. Our contribution guide is found here: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md

Debugging this would require stepping through the code with a debugger and see where/why