Support `Binary` body encoding via allowing a File Upload

louislam / uptime-kuma

A fancy self-hosted monitoring tool

https://uptime.kuma.pet

MIT License

59.98k stars 5.36k forks source link

Support `Binary` body encoding via allowing a File Upload #4721

Open ltx0633 opened 6 months ago

ltx0633 commented 6 months ago

⚠️ Please verify that this question has NOT been raised before.

[X] I checked and didn't find similar issue

🛡️ Security Policy

[X] I agree to have read this project Security Policy

📝 Describe your problem

I have an interface where the post content submitted is binary, but kuma just doesn't support it

📝 Error Message(s) or Log

No response

🐻 Uptime-Kuma Version

latest

💻 Operating System and Arch

centos

🌐 Browser

any

🖥️ Deployment Environment

Runtime: k8s
Database: sqlite
Filesystem used to store the database on: nfs
number of monitors: 10

chakflying commented 6 months ago

What UI do you think would be suitable for inputting a binary body for your request?

ltx0633 commented 6 months ago

What UI do you think would be suitable for inputting a binary body for your request?

I use the following command to detect the service curl -XPOST https://${my_services} --data-binary '@install.bin'

CommanderStorm commented 6 months ago

What Nelson was probing for is not how you are currently doing this, but rater how this should work. I think another Body Encoding => file upload field might be the best solution.

CommanderStorm commented 6 months ago

On another note:

Filesystem used to store the database on: nfs

Please see the warnings in our wiki/readme:

[!WARNING] Filesystem support for POSIX file locks is required to avoid SQLite database corruption. Be aware of possible file locking problems such as those commonly encountered with NFS. Please map the /app/data-folder to a local directory or volume.

ltx0633 commented 6 months ago

Will this make any progress?

CommanderStorm commented 6 months ago

What do you mean? Your feature-request is not even a week old.. => not having much progress on an issue in this timeframe is normal.

I think you are a bit confused about how OpenSource works. Software is delivered "as is" (no warranty, no guarantees). We are not a company so you are not paying for deliverables/timelines.

=> if you need an additional feature, you can:

developing it and contribute the change upstream (see our contribution guide).
Give the pull request a 👍🏻 to give others a better insight in what the rest of the community wants/needs
sponsor the project or write out a bounty on this PR..

CommanderStorm commented 6 months ago

In case you just wanted to unblock yourself: Uptime Kuma does have the push-monitor. See https://github.com/louislam/uptime-kuma/tree/master/extra/push-examples for examples on how this can be used.