Closed GAS85 closed 4 months ago
But 200 is correct:
index.html
=> 200 - OK
.socket.io
server is successfull
=> 200 - OK
We don't have a POST
Request for the login field. Idk what you are talking about.
The only POST
(which is returning ok
=> you likely looked at this part) is happening as part of the socket.io
workaround for broken websockets (i.e. the websocket upgrade mechanism):
https://socket.io/docs/v3/how-it-works/#http-long-polling
This login information is send via the websocket connection (as the rest of the apps communication):
See https://github.com/louislam/uptime-kuma/issues/759 for another issue in the same.
This will help to improve service with e.g. Fail2ban [...]
Can you provide a CONCRETE example? Fail2ban reads logfiles and blocks ip adresses accoding to https://github.com/fail2ban/fail2ban => the status code should not matter
This will help to improve service with e.g. [...] any status monitoring systems.
Please provide further details.
I see, when Webservices are broken there is a POST Request:
Basically even in standard fail2ban package there are few services preconfigured with even exact 401 error:
And basically many more with some manual setup, e.g. Harden Nextcloud 17+ with Fail2Ban, GUI and WebDAV - Ubuntu 20.04
there are few services preconfigured with even exact 401 error
Well there are also a few configured with the messages that we already publish as noted in https://github.com/louislam/uptime-kuma/issues/3754#issuecomment-1722419358 See Bitwarden for example..
I don't see value in refactoring the login page to POST
'ing with 200
/401
responses.
This should be solvable with the tools that we already supply...
This can work too, thanks π
π I have found these related issues/pull requests
E.g. #3754
π·οΈ Feature Request Type
API / automation options
π Feature description
Use HTTP codes in API that are relevant to the action. E.g. currently everything is
200
. Even when User tries to login with wrong User name or Password, answer on aPOST
Request will be200
with bodyok
. But it is not ok :smile:.βοΈ Solution
Here answer should be
401
Unauthorized. This will help to improve service with e.g. Fail2ban or any status monitoring systems.β Alternatives
No response
π Additional Context
No response