louislam / uptime-kuma

A fancy self-hosted monitoring tool
https://uptime.kuma.pet
MIT License
60.34k stars 5.4k forks source link

fix: slug input #5239

Closed Zoobdude closed 17 hours ago

Zoobdude commented 1 month ago

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

Description

When specifying a URL slug with UPPERCASE characters in it, it is automatically converted to lowercase by the backend, however, the browser redirects you to the uppercase version causing this 'no slug?' error.

https://github.com/user-attachments/assets/874b8651-a315-4116-a670-0e6632fa839d

It seems to also be shown in #1814 (though part of that issue is todo with it being hosted on Replit).

Type of change

Please delete any options that are not relevant.

Checklist

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

louislam commented 1 month ago

Good catch. Make me wondering if the slug should be case sensitive or insensitive.

Zoobdude commented 2 weeks ago

Sorry this took far too long @louislam. I agree that making a the slug not case sensitive is probably logical, so I've implemented that.