louislam / uptime-kuma

A fancy self-hosted monitoring tool

https://uptime.kuma.pet

MIT License

60.32k stars 5.4k forks source link

New monitor type: pterodactyl node #5288

Closed BothimTV closed 3 weeks ago

BothimTV commented 3 weeks ago

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

[x] I have read and understand the pull request rules.

Description

I implemented pterodactyl nodes as a monitor type to be able to monitor nodes without needing much knowledge about the api in order to workaround via the http check.

Type of change

New feature (non-breaking change which adds functionality)

Checklist

[x] My code follows the style guidelines of this project
[x] I ran ESLint and other linters for modified files
[x] I have performed a self-review of my own code and tested it
[x] I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
[x] My changes generates no new warnings
[ ] My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

CommanderStorm commented 3 weeks ago

I don't think this fits (they all monitor something quite general) into the other monitors we offer, nor does this seem like a difficult monitor to implement using the http monitor.

Since a yes/maybe would be forever, I think it is just fair to reject this monitor at the earliest possibility we get. This should be done via config templates instead.

Sorry for the work you put into this